Open
Conversation
mematthias
commented
Jan 27, 2026
mematthias
commented
- Updated Nix to 0.31
- Bumped Rust Edition to 2024
- Fixed Clippy warnings
Fixed clippy warnings
mematthias
commented
Jan 27, 2026
| @@ -196,40 +211,53 @@ fn socks_from_fds(fd_count: usize) -> Result<Vec<FileDescriptor>, SdError> { | |||
| } | |||
|
|
|||
| impl IsType for RawFd { | |||
Author
There was a problem hiding this comment.
This should be looked at more closely.
mematthias
commented
Jan 27, 2026
|
|
||
| let timeout = { | ||
| if let Some(usec) = env_usec.and_then(|usec_str| usec_str.parse::<u64>().ok()) { | ||
| time::Duration::from_millis(usec / 1_000) |
Author
There was a problem hiding this comment.
Should the value really be truncated here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.