When saving, write the save to a temporary file first#311
Open
kevinfoley wants to merge 2 commits intoluciusDXL:masterfrom
Open
When saving, write the save to a temporary file first#311kevinfoley wants to merge 2 commits intoluciusDXL:masterfrom
kevinfoley wants to merge 2 commits intoluciusDXL:masterfrom
Conversation
…ary file into the final destination path. This way, if the game crashes while writing the save file, we don't have any risk of overwriting a valid save with a corrupted save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After writing the temporary file, move it to the final destination path. This way, if the game crashes while serializing and writing the save file, we don't have any risk of overwriting a valid save with a corrupted save.
You might prefer to implement this a different way; if so, just close the PR.