Add skip_transaction support to single migrations#1021
Draft
pauldps wants to merge 2 commits intoluckyframework:mainfrom
Draft
Add skip_transaction support to single migrations#1021pauldps wants to merge 2 commits intoluckyframework:mainfrom
skip_transaction support to single migrations#1021pauldps wants to merge 2 commits intoluckyframework:mainfrom
Conversation
skip_migration support to single migrationsskip_transaction support to single migrations
|
A Crystal newb enters the chat I agree that the language "skip_transaction" isn't ideal -- because transactions are never skipped within the database. I think what we are trying to express to other developers is, "I won't BEGIN a new transaction for you; I'll let you handle your own transactional semantics." Question is... what the hell to short-hand that to?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for calling
skip_transaction trueinside themigratemethod in a single migration so that the statements are run outside the default transaction.Motivation / real example (CockroachDB does not allow that ALTER TABLE inside a transaction):
▸ Error message unimplemented: ALTER COLUMN TYPE is not supported inside a transaction. Query ALTER TABLE users ALTER COLUMN username TYPE STRING(30) COLLATE "en-US-u-ks-level2";.TODO: