Fixing a bug in redirect_back when query params would fail to match t…#2014
Merged
Fixing a bug in redirect_back when query params would fail to match t…#2014
Conversation
…he referer because resource was used. Fixes #1889
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1889
Description
There was a little inconsistency between
previous_urlandredirect_backthat caused some issues. Whenrequest.resourceis used, that will include any query params. So when you do a comparison betweenrequest.resource == referer_paththis might look likeif "/path?a=1" == "/path".Checklist
crystal tool format spec src./script/setup./script/test