Seed task uses log instead of puts#706
Open
jkthorne wants to merge 1 commit intoluckyframework:mainfrom
Open
Conversation
jwoertink
reviewed
Dec 8, 2021
Member
jwoertink
left a comment
There was a problem hiding this comment.
I like the idea of being able to suppress the output, but if it's just Log, then you'd have to turn that off globally which might not be wanted. We could look at doing something like LuckyTask::Log.info, then you can tune it for tasks specifically... But really, I think maybe this should actually be output.puts and use the output property on LuckyTask
Then maybe we add a habitat config for tasks that allow you to just turn off all output. What do you think about going with one of those approaches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves to use puts so you can suppress output if you want.