Replacing Turbolinks with @hotwired/turbo#726
Replacing Turbolinks with @hotwired/turbo#726rmarronnier wants to merge 1 commit intoluckyframework:mainfrom
Conversation
|
Not sure why all of the CI is failing, but I've added this in to the website luckyframework/website#932 We can test on a live site that it's fine before making the final merge. |
jwoertink
left a comment
There was a problem hiding this comment.
We will need the HTML head tags updated as well
|
Yes, the CI is failing and because the global specs using the support
Maybe it's enough, but I wanted to create specific lucky flowspecs to check we have the same behavior between before (@rails/ujs + turbolinks) and after (@hotwired/turbo only). (Problem B) Right now, only the I have to tackle problem A before working on problem B, or I'll tiptoe in the dark, wondering why the specs failed. Also for reference/note to myself : https://github.com/hotwired/turbo-rails/blob/main/UPGRADING.md I'll put this PR as draft because, it's not ready as it is. I don't have bandwidth right now to work on this but anyone is welcome to continue this :-) Oups ! Sorry for the accidental closing ! |
|
Looks like this just became a bit larger of a PR: Then whatever needs to be done to ensure this stuff works luckyframework/website#947 Just dropping these links here so we have a spot to reference them. |
Sister PR of luckyframework/lucky#1648