Skip to content

Fixing issues with generated projects #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwoertink merged 4 commits into from
Jan 11, 2026
Merged

Fixing issues with generated projects #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a62a0f
Fixing generated project formatting issues
jwoertink Jan 10, 2026
19c50db
Fixing compile-time error when loading manifest on generated projects
jwoertink Jan 10, 2026
a056ec0
Generate an initial asset manifest on setup so tasks will run properly
jwoertink Jan 10, 2026
1a2a440
Update javascript dependencies for generated projects
jwoertink Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/browser_app_skeleton/package.json.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "module",
"dependencies": {
"@rails/ujs": "^7.1.0",
"modern-normalize": "^2.0.0"
"modern-normalize": "^3.0.1"
},
"scripts": {
"heroku-postbuild": "yarn build",
Expand All @@ -14,9 +14,9 @@
"watch": "vite build --watch"
},
"devDependencies": {
"sass": "^1.69.5",
"vite": "^5.0.0",
"sass": "^1.97.2",
"vite": "^7.3.1",
"vite-plugin-compression": "^0.5.1",
"vite-plugin-dev-manifest": "^1.2.1"
"vite-plugin-dev-manifest": "^1.4.1"
}
}
2 changes: 1 addition & 1 deletion src/web_app_skeleton/config/server.cr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ end
private def raise_missing_secret_key_in_production
puts "Please set the SECRET_KEY_BASE environment variable. You can generate a secret key with 'lucky gen.secret_key'".colorize.red
exit(1)
end
end
3 changes: 3 additions & 0 deletions src/web_app_skeleton/script/setup.cr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ print_done
notice "Installing node dependencies"
run_command "yarn", "install", "--no-progress"

notice "Building initial asset manifest"
run_command "yarn", "build"

print_done
<%- end -%>

Expand Down
6 changes: 3 additions & 3 deletions src/web_app_skeleton/src/app.cr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ require "./shards"
# In development, vite-plugin-dev-manifest creates public/manifest.dev.json
# In production, Vite creates public/.vite/manifest.json
# The manifest path is determined by which file exists at compile time
{% if File.exists?("public/manifest.dev.json") %}
{% if file_exists?("public/manifest.dev.json") %}
Lucky::AssetHelpers.load_manifest "public/manifest.dev.json", use_vite: true
{% elsif File.exists?("public/.vite/manifest.json") %}
{% elsif file_exists?("public/.vite/manifest.json") %}
Lucky::AssetHelpers.load_manifest "public/.vite/manifest.json", use_vite: true
{% else %}
# For initial compilation, we'll assume development mode
Expand Down Expand Up @@ -38,4 +38,4 @@ require "./components/**"
require "./pages/**"
<%- end -%>
require "../db/migrations/**"
require "./app_server"
require "./app_server"
Loading