Open
Conversation
Member
|
Does this change the manifest file? Another thing I haven't checked yet is how images are handled... those still have to get into the manifest for the asset stuff. |
Member
Author
|
So here's the behavior I see:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #916
Fixes #913
These changes do two things:
Updates ignored to everything that is not
src,public, orvite_config.jsThis fixed
lucky devnot showing changes when I updatedsrc/css/app.cs.The existing ignored where we excluded everything then added back the above is apparently not well supported in the vite tooling (at least that is what Claude tells me). Also, I did experience the 100% cpu usage on a previous attempt but this does not have that issue.
Removes
publicDirIt seems that vite does not like having
publicDirbe a subdirectory ofoutDir. I believe this also fixed the problem for me where compiled js/css were ending up in both thepublic/assets/andpublic/directories but I haven't tested it very much.I have never used Vite before and these changes were made by Claude so take all of this with a grain of salt