Async and error handling features#24
Conversation
|
Pulsar is used in: https://github.com/luckyframework/breeze |
| ```crystal | ||
| Database::QueryEvent.subscribe do |event, duration| | ||
| puts Pulsar.elaspted_text(duration) # "2.3ms" | ||
| puts Pulsar.elapsed_text(duration) # "2.3ms" |
jwoertink
left a comment
jwoertink
left a comment
There was a problem hiding this comment.
This is awesome! I don't really see anything bad here. Looks like it just adds the new feature but keeps the old code alone. Plus the added benefit of error handling. I guess the lint CI failed due to ameba being so outdated lol.
|
@jwoertink : I tried to update the ameba version to fix the ci. I don't know if it's the way. You can merge if you want or wait for other comments :-) |
|
@rmarronnier Yeah, I think bumping it up fixed the compilation error, but now there's just the few small linting errors. I think outside of those it should be all good 👍 |
2 participants
Made with Claude Code.
Still not sure if Pulsar is meant to be used out of avram logging context