Updated libraries and remove obsolete ones#7
Open
rmotyka wants to merge 1 commit intoluizalabs:masterfrom
Open
Updated libraries and remove obsolete ones#7rmotyka wants to merge 1 commit intoluizalabs:masterfrom
rmotyka wants to merge 1 commit intoluizalabs:masterfrom
Conversation
lucaspolo
approved these changes
Jul 3, 2023
deniscapeto
reviewed
Jul 7, 2023
Collaborator
deniscapeto
left a comment
deniscapeto
left a comment
There was a problem hiding this comment.
Thanks for the collaboration. A few comments.
| throw new ArgumentNullException(nameof(redisOptions.RedisConnectionConfiguration)); | ||
|
|
||
| collection.AddDistributedRedisCache(options => options.Configuration = redisOptions.RedisConnectionConfiguration); | ||
| collection.AddStackExchangeRedisCache(options => options.Configuration = redisOptions.RedisConnectionConfiguration); |
Collaborator
There was a problem hiding this comment.
Could you add more details to the PR description? Did you consider creating another extension instead of changing this one?
| <PackageReference Include="Microsoft.Extensions.Caching.Redis" Version="2.1.2" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" /> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.1.1" /> | ||
| <PackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="7.0.8" /> |
Collaborator
There was a problem hiding this comment.
Same thing here, did you consider creating another extension?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.