Execute callback on operation finish#34
Open
Sebmaster wants to merge 1 commit intolvbreda:masterfrom
Sebmaster:fix-34
Open
Execute callback on operation finish#34Sebmaster wants to merge 1 commit intolvbreda:masterfrom Sebmaster:fix-34
Sebmaster wants to merge 1 commit intolvbreda:masterfrom
Sebmaster:fix-34
Conversation
Adds a callback parameter to all the modify operations. Additionally removes the callback parameter of the find methods since it wasn't used anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a callback parameter to all the modify operations.
Additionally it removes the callback parameter of the find methods since it wasn't used
anyway.
It might be worth thinking about reintroducing the callback parameter to the find methods and always executing them on any change i.e. give them via a parameter to the observe method and execute them before the angular scope apply().
On the other hand it's possible to
$watch()the changes on the object anyway with the fixes from my other pull requests, so that might not be needed after all.