Skip to content

Refactor tab bar runtime hooks and enable strict Swift settings#18

Merged
lynnswap merged 3 commits intomainfrom
codex/strict-swift-settings-and-agents
Mar 6, 2026
Merged

Refactor tab bar runtime hooks and enable strict Swift settings#18
lynnswap merged 3 commits intomainfrom
codex/strict-swift-settings-and-agents

Conversation

@lynnswap
Copy link
Owner

@lynnswap lynnswap commented Mar 6, 2026

Summary

Refine the internal tab bar runtime integration, enable stricter Swift package settings, and document the package testing workflow.

Changes

  • add package-level testing guidance in AGENTS.md, including the simulator-based test entry point for the public UIKit package
  • enable strict Swift settings in Package.swift and route Objective-C runtime bridging through ObjectiveCInterop.swift to satisfy stricter memory-safety checks
  • replace UITabBar item setter interception with a layout-driven runtime bridge while preserving the More-tab selection override
  • make long-press gesture synchronization idempotent, avoid duplicate recognizers across repeated layout passes, and recover the current tab index from the source view when needed
  • expand tests to cover layout callbacks, item and view controller updates, repeated layout passes, RTL/LTR fallback ordering, and stale recognizer index recovery

Testing

  • xcodebuild test -scheme TabBarMenu-Package -destination 'platform=iOS Simulator,name=iPhone 17,OS=latest' -parallel-testing-enabled NO -maximum-concurrent-test-simulator-destinations 1 -quiet
  • codex-review --uncommitted

UI Changes

  • None

Related Issues

  • None

Copy link
Owner Author

@lynnswap lynnswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap lynnswap merged commit 4523127 into main Mar 6, 2026
2 checks passed
@lynnswap lynnswap deleted the codex/strict-swift-settings-and-agents branch March 6, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant