Refactor tab bar runtime hooks and enable strict Swift settings#18
Merged
Refactor tab bar runtime hooks and enable strict Swift settings#18
Conversation
lynnswap
commented
Mar 6, 2026
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine the internal tab bar runtime integration, enable stricter Swift package settings, and document the package testing workflow.
Changes
AGENTS.md, including the simulator-based test entry point for the public UIKit packagePackage.swiftand route Objective-C runtime bridging throughObjectiveCInterop.swiftto satisfy stricter memory-safety checksUITabBaritem setter interception with a layout-driven runtime bridge while preserving the More-tab selection overrideTesting
xcodebuild test -scheme TabBarMenu-Package -destination 'platform=iOS Simulator,name=iPhone 17,OS=latest' -parallel-testing-enabled NO -maximum-concurrent-test-simulator-destinations 1 -quietcodex-review --uncommittedUI Changes
Related Issues