-
Notifications
You must be signed in to change notification settings - Fork 0
Refactored client #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PierreMarguerie
wants to merge
31
commits into
dev
Choose a base branch
from
ref/client
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactored client #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pointer instead of ids
…callback functions
775528e to
3ed918f
Compare
ElectronicIV
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues closed
this PR closes already closed issues
Summary
Basically changed the whole client architecture.
Changes
The client is now an app featuring a thread safe queue to treat the network input, the network output is treated by a system and a service(encapsulating the queue) to pass in the system contructors.
Breaking changes
Since IO and
Gameare not running in the same thread, IO callbacks need to push a function to an actionQueue (thread-safe) that themainthread will pop and execute to avoid concurrency.Here's how to use this queue (packet spawn for example):
Inside the "registerAllCallbacks" method:
It will then be called like this:
Callback action; while (_actions.pop(action)) { action(_toolbox); }Additional Notes
For additional explication about the usage of the different classes, man wiki.