Fika Integration #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event errors when Fika isn't installed.
Author
|
Ah! I forgot to mention, there are a few build warnings thanks to including fika in the references, I could've fixed them but it would've required me to have basically re-created the .csproj from scratch and I felt that was a little outside my scope 😅 I also forgot I disabled the isDayTime check for fika clients. there's two solutions to that one, either we just sync the result of isDayTime from the host to clients or we use an alternate method of getting isDayTime, as the one used currently is always null as a fika client. I'm unsure of the significance of the isDayTime check so unsure if it causes much of an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds full Fika Sync using packets. the host sends any relevant data the clients can't obtain themselves to restore functionality to clients.
I've had to seperate the packet's themselves into a seperate project/dll to be included. I couldn't find any other way to implement fika as a soft dep without causing errors when you don't have fika installed. You'll need to build packets/BossNotifier.fika.csproj at least once so it's included in future builds of BossNotifier. BossNotifier.fika.dll and BossNotifier.dll both need to be included if you have fika installed.