-
Notifications
You must be signed in to change notification settings - Fork 9
SPT 4.0 Support + optional FIKA support #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fika Support (optional)
|
Nice work, thank you! I'll merge these and push out an update when I get the chance to test. Only thing I see is that you may not want to include the intel center level in the shared packet. That way clients with upgraded hideouts can still use the mod. Great work man. I appreciate you updating the build script as well! |
|
Great job! Maybe the FIKA support should be loaded dynamically. |
|
I'll take a look at both these concerns. (and yes, fika should be loaded dynamically 😇) |
|
https://github.com/m-barneto/BossNotifier/blob/server-component/Client/Plugin.cs Has some info regarding a soft dependency on Fika. Although I had to use reflection for my fika methods doing it this way. |
Split Fika integration into separate BossNotifier.FikaOptional.dll.bin assembly to support optional Fika. Main plugin loads .bin file conditionally when Fika is detected, allowing mod to work in both singleplayer and multiplayer modes without errors. This removes the need for complex reflection throughout the Fika integration code - FikaIntegration.cs uses direct references while remaining optional.
|
@m-barneto take a look at this approach. This seems to be much more easy to handle/maintain without so much complex reflection. Also this seems like a good approach of separation of services/features. Let me know, what you think about it. :) Fixed:
Let me know if you have any concerns or find any problems testing (also directed at players, not especially m-barneto; I don't want to pile so much work on you, but rather take some off your plate. Just everyone who wants to test/use the early version) |
|
Hi @m-barneto, did you have any time to look at this? Or may we temporarly link to a prerelease version hosted on my github until you find time to take over development again? |
Hi @m-barneto,
I updated your wonderful mod to SPT 4.0 compatibility and added (optional) support for FIKA.
Pleas let me know, if the code changes align with your vision and hopefully find their way into your repo. In the meantime, can we allow palyers to use this version with it's assets for an early SPT 4 build? Of course all credits remain with you as the original author.
This is purely to help the community access your great work while we wait for your official update. The MIT license allows this, but out of respect for your work and to comply with the SPT content guidelines, I wanted to ask.
Please let me know if this is acceptable to you.
Thanks again for all your contributions to the SPT modding scene!
See the asset at https://github.com/Beat2er/BossNotifier/releases/tag/2.0