Add Twitter and GitHub icons using Font Awesome at contact section#210
Add Twitter and GitHub icons using Font Awesome at contact section#210Akash72077 wants to merge 1 commit intom-lab:mainfrom
Conversation
|
hey @Akash72077 good catch, but this seems to overlap with the PR #183. also, just a quick heads-up that the contribution guidelines recommend discussing changes before opening a PR. |
Thank you for the clarification. I had requested access to the mailing list to discuss the change beforehand, but I haven’t been added yet. Since I didn’t have access to the discussion channel, I proceeded with the PR, which led to the overlap. Could you please let me know the best place to discuss proposed changes while waiting for mailing list approval? I’d like to ensure I follow the correct process moving forward. |
|
No worries @Akash72077, they will usually accept those requests quickly, within one or two days only. before opening any new issues or PRs, make sure to read through agents.md and the contribution guidelines once to get familiar with the workflow. |
Changes
No layout issues introduced.