-
Notifications
You must be signed in to change notification settings - Fork 7
Memory leak fixes #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ixes (dont even create subs in the first place)
|
Already asked for a dll in the other PR. I have small stutters after playing one map, that get progressively worse over time (rotation of your ship stutters ever so slightly) . I know memory leaks existed, but didnt really knew how to figure this out. This could be really helpful and might fix my stuttering. |
|
https://drive.google.com/file/d/1XthU7h6tmLR5xfpVqGC6Wjh4lGbExfQ7/view?usp=sharing After renaming, you should be able to just drop-in replace it for the main .dll To enable set "MemoryLeakFix" = true, in your settings.json I'd be surprised if this particular fix addressed your stuttering, there are many other larger leaks to be plugged. But who knows for sure until you try it? |
|
Well the amount of message center subscriptions was probably the issue. Without your fix: small stuttering (would increase the more I load) However i did have a floating mechicon (atlas) from the mechbay when switching screens during normal usage. That went away when switching to and away from the mechbay again. |
First iteration of a set of fixes that aim to resolve memory leaks in the game.
This set of fixes targets mostly message subscriptions that are added but never properly removed. This inflates not only the size of the MessageCenter, but leaks a large number of objects by having references to them persist in the MessageCenter.
Saves ~70MB per contract that's been completed.