Skip to content

Comments

Tooltip Component Added#7

Open
m26unkwn wants to merge 1 commit intodevfrom
tooltip
Open

Tooltip Component Added#7
m26unkwn wants to merge 1 commit intodevfrom
tooltip

Conversation

@m26unkwn
Copy link
Owner

@m26unkwn m26unkwn commented Mar 28, 2022

You can give the review to the ToolTip Component
You can go to the link and hover any navbar icon to check whether it's working or not.

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for extraordinary-khapse-eca0c1 ready!

Name Link
🔨 Latest commit 3ccd73c
🔍 Latest deploy log https://app.netlify.com/sites/extraordinary-khapse-eca0c1/deploys/6241efcfd15782000844092f
😎 Deploy Preview https://deploy-preview-7--extraordinary-khapse-eca0c1.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@muskanbagrecha muskanbagrecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to understand the usecase. We can directly use the title attribute right? This is also better for assistive technology.
As in this doc

Please correct me if I'm wrong.

@m26unkwn
Copy link
Owner Author

m26unkwn commented Mar 28, 2022

I'm trying to understand the usecase. We can directly use the title attribute right? This is also better for assistive technology. As in this doc

Please correct me if I'm wrong.

What I know about Tooltip is it is not good for touch screens.

In my case, I am trying to make it modular so right now it is not but in the future, I will add something which will be dependent on screen width ..

@m26unkwn m26unkwn closed this Mar 28, 2022
@m26unkwn m26unkwn reopened this Mar 28, 2022
Copy link

@saurabhchirde saurabhchirde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any issue, as Muskan has already suggested some.
Looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants