Open
Conversation
added 7 commits
March 23, 2016 00:28
|
Yes, please, @m4i ! |
|
yes plz |
durandom
added a commit
to durandom/rubocop-git
that referenced
this pull request
Mar 17, 2017
Added auto correct with -a flag
durandom
added a commit
to durandom/rubocop-git
that referenced
this pull request
May 2, 2017
Added auto correct with -a flag
Closed
|
Are there plans to add this to the main repo's master branch? |
|
/cc @m4i |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the ability to use rubocop's -a flag and only autocorrect the code that git diff views as added.
it does this by first mapping out the changed lines by some small edits to the patch.rb file
it then takes that those line numbers and adds rubocop en/disable comments to the files around the edited code disabling all other code from being processed by rubocop, while adding lines it maps out what lines its editing
after rubocop runs its validations we then go back though using the edited lines map we remove the added comments. We do this to avoid removing rubocop comments that might already exist in the project