Skip to content

Fix Exclude bug#23

Open
dkniffin wants to merge 1 commit intom4i:masterfrom
dkniffin:bug/excluded-cop-files-not-excluded
Open

Fix Exclude bug#23
dkniffin wants to merge 1 commit intom4i:masterfrom
dkniffin:bug/excluded-cop-files-not-excluded

Conversation

@dkniffin
Copy link
Contributor

Before, if you did something like:

Documentation:
  Exclude:
    - 'subdir/**/*.rb'

It wouldn't actually exclude that. It was because rubocop looks for those exclusions using an absolute path for the file name.

@dkniffin
Copy link
Contributor Author

I'll look into this more, but it has to do with the filename being wrong in the git show commands in lib/rubocop/git/commit.rb, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant