Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When almostnode's library is built by Vite,
new URL('./worker/runtime-worker.ts', import.meta.url)inWorkerRuntimeis transformed intonew Worker(new URL("/assets/runtime-worker-<hash>.js", import.meta.url), ...)indist/index.mjs.Turbopack (and Webpack) statically analyze
new URL(..., import.meta.url)at build time and fail when the path is a server-relative/assets/...URL — they can't find the file in the consuming project's asset pipeline.The fix in practice
Before (breaks Turbopack/Webpack — they try to resolve the asset at build time):
After (works with any bundler):
The default behavior (no
workerUrl) is unchanged — Vite users are unaffected.