Skip to content

Conversation

@KSkwarczynski
Copy link
Member

@KSkwarczynski KSkwarczynski commented Jan 20, 2026

Pull request description

Another PR towards "flexible binning".

This focused on how we provide binning in yaml config so this is new format:

  Binning:
    VarStr : [ "RecoNeutrinoEnergy", "TrueQ2" ]
    VarBins: [ [0.,  0.5,  1.,  1.25, 1.5, 1.75, 2., 2.25, 2.5, 2.75, 3., 3.25, 3.5, 3.75, 4.],
               [0.,  0.5,  1.,  1.25, 1.5, 1.75, 2.] ]
    Uniform: true

XVar, YVar was impossible to expand beyond 2D :(

Also GetMCHist no longer require dimension. We do have Get1DVarHist for actual projections.
GetMCHist returns actually used histogram.

For more see: mach3-software/MaCh3Tutorial#212

Changes or fixes

  • SampleInfo no longer stores pointer to 1D, 2D hist but we now use actual inheritance of TH1...
  • GetPDF now equal GetMCHist as both had same functionality (small step towards ND-FD unification)

Examples

Bez tytułu

@github-actions
Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@KSkwarczynski KSkwarczynski merged commit 97cf473 into develop Jan 21, 2026
26 checks passed
@KSkwarczynski KSkwarczynski deleted the kskwarczysnki/breaking/BinningFormat branch January 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MCMC MCMC related Samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants