Add component mapping to alerts by sradco · Pull Request #8 · machadovilaca/monitoring-plugin

sradco · 2026-01-05T16:51:00Z

Added a mapping of layer(cluster/namespace) and
component to alerts.

Based on openshift/enhancements#1917

sradco · 2026-01-11T21:28:03Z

Hi @machadovilaca , @avlitman, @simonpasquier Hi, Please review this PR.

simonpasquier · 2026-01-12T14:22:25Z

I thought that development was supposed to happen in https://github.com/openshift/monitoring-plugin/?

machadovilaca · 2026-01-12T15:12:16Z

I thought that development was supposed to happen in https://github.com/openshift/monitoring-plugin/?

@simonpasquier these PRs are against the branch used for openshift#657
as long as that one is not merged to the feature branch in openshift/monitoring-plugin, we can't open PRs there

internal/managementrouter/classification_update.go

internal/managementrouter/router.go

pkg/k8s/alert_classification_configmap.go

sradco · 2026-01-15T18:56:20Z

@machadovilaca I updated the PR based on your feedback. Please review.

simonpasquier · 2026-01-16T09:06:22Z

as long as that one is not merged to the feature branch in openshift/monitoring-plugin, we can't open PRs there

As it has been communicated elsewhere, we wont' be able to review a giant PR in openshift/monitoring-plugin. My expectation was that we would review PRs directly in openshift/monitoring-plugin.

sradco · 2026-01-16T10:34:03Z

@simonpasquier once we will finish adding all the features to the branch I will split it to logical commits.

sradco · 2026-01-19T10:39:08Z

/hold

sradco · 2026-01-21T15:25:29Z

/unhold

sradco · 2026-01-21T15:26:04Z

Hi @machadovilaca , @avlitman, Hi, Please review this PR.

pkg/management/update_platform_alert_rule_test.go

pkg/management/update_user_defined_alert_rule_test.go

sradco · 2026-02-11T11:30:27Z

Hi, I rebased this PR. Please review @avlitman @machadovilaca

internal/managementrouter/alert_rule_bulk_update.go

pkg/management/update_user_defined_alert_rule.go

machadovilaca · 2026-02-11T12:15:25Z

pkg/management/update_classification.go

+	Component        *string `json:"openshift_io_alert_rule_component,omitempty"`
+	ComponentSet     bool    `json:"-"`


whats the difference between nil and ComponentSet false?

If ComponentSet == false: don’t change anything (leave whatever is stored today).
If ComponentSet == true and Component == nil: clear it (remove the override).
If ComponentSet == true and Component != nil: set it to that string.

Examples:

No change (field omitted):
{ "classification": { } }
or omit classification entirely.

Clear:
{ "classification": { "openshift_io_alert_rule_component": null } }

Set:
{ "classification": { "openshift_io_alert_rule_component": "network" } }

pkg/management/delete_user_defined_alert_rule_by_id.go

pkg/k8s/relabeled_rules.go

pkg/k8s/prometheus_alerts.go

pkg/alert_rule/alert_rule.go

pkg/alertcomponent/matcher.go

machadovilaca

after fixing the current comments, looks good to me
im just not sure about the double pointers, but we can revisit later

pkg/alertcomponent/matcher.go

pkg/k8s/types.go

pkg/management/new.go

Document classification endpoints and implement router handlers for single and bulk updates. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Persist classification overrides in a ConfigMap and merge effective values into alert responses. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Add component/layer matching logic used to classify rules and alerts. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Add k8s helpers and alert enrichment needed to compute and expose rule classification defaults. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

sradco changed the title ~~Add component mapping to alert rules~~ [WIP]Add component mapping to alert rules Jan 5, 2026

sradco force-pushed the add_alert_rule_mapping branch 3 times, most recently from 8feaad6 to 20f8b4d Compare January 7, 2026 09:16

sradco changed the title ~~[WIP]Add component mapping to alert rules~~ Add component mapping to alert rules Jan 12, 2026

sradco force-pushed the add_alert_rule_mapping branch from 20f8b4d to 8d7e4c6 Compare January 12, 2026 13:11

machadovilaca reviewed Jan 14, 2026

View reviewed changes

sradco force-pushed the add_alert_rule_mapping branch from 8d7e4c6 to 887f95f Compare January 15, 2026 18:52

sradco changed the title ~~Add component mapping to alert rules~~ Add component mapping to alerts Jan 19, 2026

sradco force-pushed the add_alert_rule_mapping branch 9 times, most recently from bddde87 to 9ac6b3a Compare January 21, 2026 15:17

avlitman reviewed Jan 21, 2026

View reviewed changes

pkg/management/update_platform_alert_rule_test.go Outdated Show resolved Hide resolved

avlitman reviewed Jan 21, 2026

View reviewed changes

pkg/management/update_user_defined_alert_rule_test.go Outdated Show resolved Hide resolved

avlitman reviewed Jan 21, 2026

View reviewed changes

pkg/management/update_user_defined_alert_rule_test.go Outdated Show resolved Hide resolved

sradco force-pushed the add_alert_rule_mapping branch from 8cad9bf to 8d065c3 Compare February 11, 2026 11:28

machadovilaca reviewed Feb 11, 2026

View reviewed changes

sradco force-pushed the add_alert_rule_mapping branch 3 times, most recently from ba1d756 to ce4cdbf Compare February 17, 2026 13:59