bump to v0.11.2 and add 5.2 support #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ternary operator failed travis check
travis
|
Currently unable to upgrade to 5.2.0 due to this. Anything holding this back? |
Author
|
Looks like it's an issue with the formtastic gem when travis does its checks. I just got back from RailsConf so I'll have a look at it in the AM and submit a fix |
Author
|
Issue was actually with simple_form. Fixed now. |
|
Is a release in the works? |
Author
|
This PR is ready to be merged. I'm using this gem in a 5.2 app by pulling it from my GitHub in the Gemfile, which you are all welcome to do until the official gem is updated. |
Author
|
@maclover7 any chance we can get this merged? |
|
yes please merge!! @maclover7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped version in gem to trix v0.11.2 and added update to allow for usage with rails 5.2