Cancel provisioning on job completion #52
Merged
+100
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases in which the agent never finishes the job, while the integration gets JobCompeted message. In this case the runner is stuck and the underlying VM is never deleted. Introduce a provisioning context that is going to cancel the provisioning when the job complete message is received. This is going to ensure that the VM and the runner are deleted and resoruces are freed. This also ensures a VM is deleted if a run is cancelled and the cancellation is never received from the VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some cases in which the agent never finishes the job, while the integration gets JobCompeted message. In this case the runner is stuck and the underlying VM is never deleted.
Introduce a provisioning context that is going to cancel the provisioning when the job complete message is received.
This is going to ensure that the VM and the runner are deleted and resoruces are freed.
This also ensures a VM is deleted if a run is cancelled and the cancellation is never received from the VM.