Skip to content

[IMPAC-739] Add new figure layout #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manu-d wants to merge 1 commit into
base: lmi-insights
Choose a base branch
from
Open

[IMPAC-739] Add new figure layout #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/components/widgets-layouts/figure/figure.directive.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
module = angular.module('impac.components.widgets-layouts.figure',[])

module.controller('FigureLayoutCtrl', ($scope, ChartFormatterSvc) ->

$scope.getColorByIndex = (index) ->
ChartFormatterSvc.getColor(index)

)

module.directive('impacFigureLayout', ($templateCache) ->
return {
restrict: 'E',
scope: {
content: '='
timePeriodEnabled: '=?'
Copy link
Contributor

@xaun xaun Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timePeriodEnabled, selectorList, and selectorUid isn't used anywhere.

selectorList: '=?'
selectorUid: '=?'
},
template: $templateCache.get('widgets-layouts/figure.tmpl.html'),
controller: 'FigureLayoutCtrl'
}
)
10 changes: 10 additions & 0 deletions src/components/widgets-layouts/figure/figure.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.analytics .layouts.figure {
Copy link
Contributor

@xaun xaun Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No styles are being applied to indicate this is a column or scrollable as specified in the JIRA.
In screenshot below I have added entries and they just extend the height of the widget.
screen shot 2018-03-19 at 11 23 56

h3 {
text-align: center;
}

.value {
.center-bold(0px);
margin-bottom: 3px;
}
}
7 changes: 7 additions & 0 deletions src/components/widgets-layouts/figure/figure.tmpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<div class="layouts figure">
<div ng-repeat="figure in content">
<h3>{{figure.label}}</h3>
<div class="value" ng-style="{'color': getColorByIndex($index)}">{{figure.value}}</div>
<div ng-show="figure.unit">{{figure.unit}}></div>
</div>
</div>
6 changes: 6 additions & 0 deletions src/impac-angular.module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ angular.module('impac.components',
'impac.components.widget',
'impac.components.widgets',
'impac.components.widgets-settings',
'impac.components.widgets-layouts',
'impac.components.widgets-common',
'impac.components.common',
'impac.components.templates'
Expand Down Expand Up @@ -118,6 +119,11 @@ angular.module('impac.components.widgets-settings',
'impac.components.widgets-settings.offsets'
]
);
angular.module('impac.components.widgets-layouts',
[
'impac.components.widgets-layouts.figure'
]
);
angular.module('impac.components.dashboard-settings',
[
'impac.components.dashboard-settings.currency',
Expand Down