Fixed a volume mount issue when source and destination path differs#8
Open
jeremyVignelles wants to merge 3 commits intomafintosh:masterfrom
Open
Fixed a volume mount issue when source and destination path differs#8jeremyVignelles wants to merge 3 commits intomafintosh:masterfrom
jeremyVignelles wants to merge 3 commits intomafintosh:masterfrom
Conversation
Author
|
I also noticed in README.md something saying: You can't have twice the same key in a JS object. Could you change the example to use two different directories there? |
Author
|
Just added a fix for the same issue, but with port mappings, but didn't add a test as I have no idea how to test this. I can only confirm that it works with my container where the container's 80 port is mapped to host's 8080 |
|
I tried this out and viewed the results in Kitematic. The folders were not linked properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had issues while mounting my containers volumes. After a quick investigation, I was able to fix the issue and publish this PR.
I also added tests for this, as well as the env option.