Conversation
Contributor
Author
|
Do you really need to support Node v4? :/ |
Owner
|
Is there any of the versions not supported on 4 or are you referring to something else? |
Contributor
Author
|
Yes, through2 v4. |
|
Would like to ask: do you still want to support node version below 12? |
Owner
|
We’ll drop that and bump major when there is a bug fix that requires it :) |
So never then 😝 How about i make a PR that modernize the code?
|
Owner
|
Sure, as long as it's Node 10+ and keep the test devs old tho (ie concat stream) so we know we don't break anything. |
|
so without ESM or node: prefix then... sure i can make such PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.