Exclude unnecessary files from the npm package #53
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listed a few additional files and folders which are currently included in the published npm package, while they should not be.
|
@pkuczynski better go with the files package.json key: "files": [
"index.js"
] |
Author
|
Why do you think it would be better? |
|
Because it's one less file and we don't need to npm ignore other files. |
Instead of instructing what is "ignored" you explicitly list what is included. Commonly less error prone 👍 |
Author
|
Fair enough. Changed to your suggestion. Let me know if I should do anything more? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listed a few additional files and folders which are currently included in the published npm package, while they should not be.