Skip to content

Conversation

@markoorn
Copy link

@markoorn markoorn commented Dec 5, 2022

I've moved the ancient check to be after the browser check to bypass the browser error:

index.js:6 Uncaught ReferenceError: process is not defined
at ../../node_modules/pump/index.js (index.js:6:29)
at __require2 (chunk-KQHTJEE7.js:18:50)
at utils.ts:25:2

@markoorn markoorn mentioned this pull request Dec 5, 2022
Copy link

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think this works it seems like an explicit check for process would be more clear in the code. Either way, adding an approval.

@markoorn
Copy link
Author

Can we merge this?

@wesleytodd
Copy link

This package is no longer necessary now that .pipeline is in core. I think this package likely should be working toward deprecation or becoming a pass through. I cannot speak for what @mafintosh thinks though, maybe there is another plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants