cross browser capability and ajax add to cart speculation issue

[5mehulhelp5]

@JaJuMa @GrimLink @rhoerr please check and let me know if you found any suggestion on that

[rhoerr]

If I understand the code correctly:

• If it's a bfcache traversal, initialize the BFCacheHandler immediately
• Otherwise, set an event on when the page is actually opened (prerenderingchange or visibilitychange) and wait until then to initialize BFCacheHandler
• ? This prevents speculation rules in prerender mode from taking a bfcache snapshot before the page is opened and using it for the speculation load ?

Is that correct? Or is there more to it?

Note that with the upcoming new release the default speculation mode here will change from prerender to preload, which should not have the state issue you mentioned (where changes to cart status won't show up on pages previously prerendered).

[rhoerr]

If a page is loaded without prerendering in Chrome/IE, does this prevent bfcache from initializing at all?

[JaJuMa]

@5mehulhelp5

I was also able to reproduce this issue, it happens when the product page was prerendered right before adding the item to the cart. In that case, the product page displays outdated content.

We’ve implemented this function to handle that situation in the BFcache template: actionRefreshMiniCart().

In my opinion, the logic for handling this issue should be placed in the speculation-rules.phtml template instead of the bfcache/handler.phtml.
Also, it might be worth considering fixing this for both the Luma and Hyvä themes.

Please review this approach and let me know your thoughts.

Thanks

[JaJuMa]

I already check again, This issue doesn't happen on Hyvä theme only on Luma
We already fix this issue by this PR #24

Issue: #20

[rhoerr]

This issue should be fixed with the merge of #24

Thank you