Skip to content

Fix invalid negative index usage when mutating last byte #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x0v4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix invalid negative index usage when mutating last byte #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/integration/tests/test-delegation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,11 @@ describe("TestDelegation", () => {
});

it("Commit a new state to the PDA", async () => {
let account = await provider.connection.getAccountInfo(pda);
let new_data = account.data;
new_data[-1] = (new_data[-1] + 1) % 256;
const account = await provider.connection.getAccountInfo(pda);
const new_data = account.data;

const lastIndex = new_data.length - 1;
new_data[lastIndex] = (new_data[lastIndex] + 1) % 256;

const args: CommitAccountInstructionArgs = {
slot: new anchor.BN(1),
Expand Down Expand Up @@ -316,9 +318,11 @@ describe("TestDelegation", () => {
});

it("Commit a new state to the PDA", async () => {
let account = await provider.connection.getAccountInfo(pda);
let new_data = account.data;
new_data[-1] = (new_data[-1] + 1) % 256;
const account = await provider.connection.getAccountInfo(pda);
const new_data = account.data;

const lastIndex = new_data.length - 1;
new_data[lastIndex] = (new_data[lastIndex] + 1) % 256;

const args: CommitAccountInstructionArgs = {
slot: new anchor.BN(2),
Expand Down