Skip to content

Security fixes: remove sensitive info from logs and clean up cookie jar on revoke #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobprezant wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security fixes: remove sensitive info from logs and clean up cookie jar on revoke #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ func loginCmd() *cobra.Command {
}

dependencies.Logger.Verbose().
Str("password", password).
Str("email", email).
Str("authCode", util.IfEmpty(authCode, "<nil>")).
Msg("logging in")

output, err := dependencies.AppStore.Login(appstore.LoginInput{
Expand Down Expand Up @@ -161,6 +159,12 @@ func revokeCmd() *cobra.Command {
return err
}

cookieJarPath := dependencies.Machine.HomeDirectory() + string(os.PathSeparator) +
ConfigDirectoryName + string(os.PathSeparator) + CookieJarFileName
if err := dependencies.OS.Remove(cookieJarPath); err != nil && !dependencies.OS.IsNotExist(err) {
return fmt.Errorf("failed to remove cookie jar: %w", err)
}

dependencies.Logger.Log().Bool("success", true).Send()

return nil
Expand Down