using DECOMPRESSORS when globally defined#56
Open
kkdd wants to merge 4 commits intomakinacorpus:masterfrom
Open
using DECOMPRESSORS when globally defined#56kkdd wants to merge 4 commits intomakinacorpus:masterfrom
kkdd wants to merge 4 commits intomakinacorpus:masterfrom
Conversation
Contributor
Author
|
It has been a long homework. Is this acceptable? |
leplatrem
reviewed
Oct 23, 2018
| ext = name.pop(); | ||
| decompressor = this._decompressors[ext]; | ||
| if (decompressor) { | ||
| ext = name.pop(); |
Collaborator
There was a problem hiding this comment.
Is this always true? You are assuming that the file will data.geojson.zip
leplatrem
reviewed
Oct 23, 2018
| var result = e.target.result; | ||
| if (parser.decompressor) { | ||
| result = parser.decompressor(result); | ||
| } |
Collaborator
There was a problem hiding this comment.
couldn't we include the decompression in the parser.processor function if a decompressor is defined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as defined in
decompressor.js: