Develop

[jackchenzlp]

Hello,

I apologize for my limited English proficiency. I am using a translation software to write this letter. I have been using your Leaflet.FileLayer project, but I wanted to add some new features. However, I found that your existing code did not allow me to incorporate these new functionalities. Therefore, I had to modify your source code to make it compatible with the additional features I needed. I am sending you the modified version based on your 1.2.0 release.

I reorganized your code using TypeScript (ts). Please forgive any inadequacies in the modifications I made. The purpose of this reorganization is to extend your Leaflet.FileLayer project. In China, the majority of file imports involve coordinates from Excel files, which is a convenient method for construction projects. For example, it is used for map coordinates in dock construction, vehicle contour coordinates, and building construction coordinates, all measured in millimeters. Excel extension files are not included in my message.

To facilitate communication, I have rebuilt version 1.2.0. I hope to receive your approval.

Here is a breakdown of the steps involved in the code generation:

Step 1: Use the tsc command in the ../leaflet.FileLayer/ts> directory to generate js and .d.ts files in the dts folder.
Step 2: In the root directory, use the npm run compile_ts command to generate leaflet.filelayer.js and leaflet.filelayer.d.ts configuration files in the src folder. These files will be automatically generated by webpack and placed in the webpack-ts-build.js file in the config folder.
Step 3: Use the npm run none command to package an uncompressed leaflet.filelayer.js file. This will allow you to view the source code in leaflet.filelayer.js.
Step 4: Use the npm run prod command to package the file into a compressed leaflet.filelayer.js.

For testing purposes, you can use the index_dist.html and index_none.html files in the test folder. These files are designed to test the leaflet.filelayer.js files in the none and dist folders respectively, in order to verify the correctness of the packaging results.

Thank you for your understanding and cooperation.

Best regards,

[jackchenzlp]

[leplatrem]

Thank you for taking the time to contribute to this repo.

I don't maintain this repo anymore, and looking at the state of the numerous pull-requests, it looks like Makina Corpus does not either. (/cc @submarcos @camillemonchicourt)

Anyway, it is very unlikely that an open source project will ever accept such a pull-request.
Why?

• the list of changes is too big. Contributions should be a lot smaller. Unless there was a solid discussion beforehand
• the pull-request touches several topics (packaging, code, etc.)
• the repo was implemented in english, adding other languages won't be accepted (chinese or french or whatever)
• the commit messages do not describe the associated changes
  Just to name a few...

Also you don't make explicit what you mean with your existing code did not allow me to incorporate these new functionalities.. You could try to give examples and describe what you miss.

Also, don't worry, you can keep your own fork with your changes. Seeing the very low activity on this repo, it should not be too much effort to pull the evolutions made here to your fork from time to time.