Use the list of files supplied by pre-commit#17
Open
navaneeth-spotnana wants to merge 15 commits intomaltzj:masterfrom
Open
Use the list of files supplied by pre-commit#17navaneeth-spotnana wants to merge 15 commits intomaltzj:masterfrom
navaneeth-spotnana wants to merge 15 commits intomaltzj:masterfrom
Conversation
updgrade the java code format version
ST-31948: Make google format work with JDK 17
Update google format to 1.15.0
upgrading formatter
ST-0: Upgrade google-java-format to 1.25.2 in order to upgrade jdk to 21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit passes a list of files according the exclusion and other rules to the script. Currently
format-code.shdoesn't respect the list, and creates its own list of files.This was leading to unwanted files getting formatted, for example, when merging.