Delete unused and deprecated MD5ArtifactComparator#2
Closed
manandbytes wants to merge 2 commits intomasterfrom
Closed
Delete unused and deprecated MD5ArtifactComparator#2manandbytes wants to merge 2 commits intomasterfrom
manandbytes wants to merge 2 commits intomasterfrom
Conversation
Test Results 12 files ± 0 12 suites ±0 15m 54s ⏱️ -43s Results for commit 85e453b. ± Comparison against base commit 79d4e8b. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
manandbytes
force-pushed
the
drop-md5-artifact-comparator
branch
from
79fe2aa to
9341378
Compare
…Verifier Since Mar'2018, artifact checksums are verified exclusively by the combination of ChecksumVerifier processing step + contributions to artifactChecksums extension point and MD5Verifier was not removed just in case [1]. Now its time to finally drop it. [1] e4b77e5
...as there are no usages in production code since Jan'2021 [1], when MirrorApplication switched to use ArtifactChecksumComparator. [1] c173ee7
akurtakov
force-pushed
the
drop-md5-artifact-comparator
branch
from
9341378 to
85e453b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as there are no usages in production code since Jan'2021 [1], when MirrorApplication switched to use ArtifactChecksumComparator.
[1] c173ee7