Enhance/33 close interpreter window when sys.exit called#110
Open
Lin1st wants to merge 5 commits intomandiant:mainfrom
Open
Enhance/33 close interpreter window when sys.exit called#110Lin1st wants to merge 5 commits intomandiant:mainfrom
Lin1st wants to merge 5 commits intomandiant:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7abe28e to
288b0b2
Compare
ff4ef7f to
2396651
Compare
2396651 to
1b8bd45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #33
Key changes:
InterpreterExitexception in Python to signal interpreter terminationInterpreterExitto a Java-side exceptionGhidrathonInterpreterExitExceptionto break out of the interpreter input threadinputThread,console,interactiveScript, andinteractiveTaskMonitor) whensys.exit()is calledInterpreterPanelServiceto ensure Ghidrathon remains available in the Ghidra’s menu after exit and let the user activate it manually laterNote: Clicking the close [X] button in the interpreter window only hides it (Ghidra's standard dockable panel behavior(?)). However, calling sys.exit() now performs a full shutdown and re-registration of the console