Added more DS3234 support to RTClib#2
Open
awickert wants to merge 11 commits intomaniacbug:masterfrom
Open
Conversation
…essary, though I don't know why, when they are called in the middle of other functions that do this in a way that encompasses the sub-function call.
… for setting hours: removed second instance and now working correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy maniacbug,
Not sure how active you still are here, but I have added a lot of additional support for the DS3234 RTC (used for the DeadOnRTC, https://github.com/sparkfun/DeadOn_RTC). Was thinking it could be good to merge into your repo, and then possibly eventually with Adafruit's (since theirs gets a lot of traffic -- and why not make the extra functionality easier to get?!).
Quick summary of changes here (see also the diffs) are:
If I don't hear from you in a few days, I may just create a pull request straight to Adafruit that would send your improvements their way as well.
And thanks for creating such a wonderful base on which I was able to
Cheers,
Andy