Conversation
Author
|
Ugh... I just realized that I was branching off the same branches, so this last PR has all of the changes. If you want some of these changes and not all of them, I am happy to do cleaner PRs for each of these from main. I did all of these changes together because they are a little dependent on each other, so thats my bad. |
…o_tox # Conflicts: # tests/api/test_integration_hubspot_api.py
Contributor
|
Hey @cylussec, Starting to have a look through your PRs for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tox is more Pythonic than Makefiles. This PR has the tox files, switches from setup.py/setup.cfg/requirements.txt to mainly using setup.cfg (which is the current standard), moves some of your black/flake8/isort checks into precommit hooks (as well as being run in Github Actions).
I can't take credit for all of this. Whenever I start a new project, I use Pyscaffold to create a lot of the base files, and a lot of these are modified files that come with that.