Use lowercase header names when reading expiry#13626
Closed
nab0y4enko wants to merge 1 commit intomapbox:mainfrom
Closed
Use lowercase header names when reading expiry#13626nab0y4enko wants to merge 1 commit intomapbox:mainfrom
nab0y4enko wants to merge 1 commit intomapbox:mainfrom
Conversation
Normalize header lookups to lowercase in getExpiryDataFromHeaders so 'cache-control' and 'expires' are retrieved reliably from Headers/Map implementations that store lowercase keys. This prevents previously returning undefined when headers used lowercase keys.
|
|
|
Hey, @nab0y4enko 👋 Thanks for your contribution to Mapbox GL JS! Important: This repository does not accept direct merges. All changes go through our internal review process. What happens next:
Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md. |
Contributor
|
Wow, good catch, thanks! |
Contributor
|
Merged as de053a3, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue 13625
Normalize header lookups to lowercase in getExpiryDataFromHeaders so 'cache-control' and 'expires' are retrieved reliably from Headers/Map implementations that store lowercase keys. This prevents previously returning undefined when headers used lowercase keys.