Skip to content

Conversation

@DGalexander
Copy link
Collaborator

@DGalexander DGalexander commented Nov 22, 2024

Summary

This PR introduces geospatial masking functionality to the MapReader project. The geospatial masking workflow leverages OS Data Hub APIs to extract and mask geospatial data, providing a foundation for enhanced map boundary detection.

Fixes #532

Describe your changes

Key Changes
Added geospatial_masking.py:

  • Implements:
  • BBOX generation.
  • API calls to OS Data Hub.
  • Mask creation and export as GeoTIFF and shapefiles.

Modified mapreader->load->images.py:

Integrated geospatial masking functions into the load subpackage.

Testing:

Added unit tests for geospatial masking in tests/test_geospatial_masking.py.

Documentation:

Updated README with usage instructions for geospatial masking.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/load/geo_utils.py 16.66% 20 Missing ⚠️
Flag Coverage Δ
unittests 77.48% <16.66%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/load/geo_utils.py 61.76% <16.66%> (-24.60%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmcdono2 kmcdono2 added new feature enhancement New feature or request labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants