Conversation
Original commit: 036ddc4fefc0374fb0cae1b3b698b7164575ec79:
… the first time RTL text is encountered. (#8865) Original commit: d69e24420d9ef4e69315d5dc590ee7e047706aa2:
…088) Original commit: 2e53e7c5ef8654f4ab7162c25103abece00919dc:
…SON sources (#9091) create mode 100644 test/util/create_symbol_layer.js Original commit: d9e9ffe39a823b2f4a790b805b4fd2859c363cc4:
…er. (#2381) * Don't reload raster sources when RTL text plugin loads to avoid flicker. Fixes issue https://github.com/maplibre/maplibre-gl-js/issue/2380 * Test fixes: - Make clearRTLTextPlugin also clear the _completionCallback - Having a completion callback for an old plugin run is bad in general - It specifically messed up the style tests by running during later tests - Call clearRTLTextPlugin when last plugin test is done - Set the stubMap style object -- this is a subtle one, but two frames _after_ this test runs, loadTileJSON triggered by this loadJSON will fail if the map doesn't have its style set, and the exception will get passed to a later style test. * Add changelog entry. Original commit: 3df594864bdf3f8713eafa6b573251dda9d89061:
* Initial commit to split rtl to worker and main thread implementations. * Finish all fixes for rtl plugin split * Fix the tests that fail, add proper idle event handling * Changelog, lint, build and render * Improve render test * Fix changelog, add idle console logging * Return a promise from the public API * Add more logs to tests * More logs, more timeout * Fix lint * Clean error for failed tests * Fix typo delete mode 100644 src/source/rtl_text_plugin.ts create mode 100644 src/source/rtl_text_plugin_main_thread.test.ts create mode 100644 src/source/rtl_text_plugin_main_thread.ts create mode 100644 src/source/rtl_text_plugin_status.ts create mode 100644 src/source/rtl_text_plugin_worker.ts Original commit: d68b919b04864d1c11491ddbc75d3f16dc2838e0:
* fire pluginStateChange only if at least one receiver changed plugin status * draft * fixes * all ut pass * test cases * change log * worker tests * add change in style.ts * update style test * update UT * Update src/source/rtl_text_plugin_main_thread.test.ts * PR comments * PR comments * dup lazyLoad() calls * multiple * PR * replace exception with console.error * update comment to be more accurate * do not download from main thread * remove extra try/catch * remove extra throw * remove extra import * exception handling * correct version * all UT * UT * add tests (#7) * all UT * UT * Add FT * remove extra import * clean up comments * test update --------- Co-authored-by: Harel M <harel.mazor@gmail.com> Original commit: 82dce2b2e57abbadffa0fdaf2452ade1ce4f11ec:
* Allow loading rtl plugin async * Allow loading rtl plugin async * Add changelog * Fix typecheck and code * Add tests to make sure both 0.2.3 and 0.3.0 are supported * Improve test name * Change to use latest version everywhere. * Revert unrelated changes create mode 100644 src/source/rtl_text_plugin_worker.test.ts Original commit: a2f1450549c9e977f6d4fcb0f249c4ffe1d6e11b:
- collate in one module - replace classes by functions - distinguish between `loader` and `plugin` instead of `main thread` and `worker` - remove unnecessary methods and rename according to intended use
it's already triggered when processing text for symbols
melitele
force-pushed
the
rtl-plugin-lazy
branch
from
9d0ac87 to
042f8d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deferredoptionsetRTLTextPluginto load the plugin only when the first time RTL text is encountered. (#8865)stringContainsRTLTextdependency from within style-spec. (#9088)mapwhitcoding conventions