Expose raw license details#27
Open
jbergknoff-rival wants to merge 2 commits intomarcello3d:masterfrom
Open
Conversation
Author
|
The failing test also fails on the master branch. I think test/self-dev.json may need to be updated. I'm kind of confused how the test passed on master two years ago. For instance, self-dev.json doesn't have [1] node-licensecheck/test/self-dev.json Lines 32 to 34 in 406af81 |
Owner
|
The project and tests are pretty old so that's not too surprising… it's likely due to the fact that there's no yarn/npm lock file to pin the sub-dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great tool, thank you!
I'm writing a wrapper around node-licensecheck to add some business rules (whitelisting). Unfortunately, the raw details of the licenses aren't exposed, only the stringified form, which is pretty difficult to cleanly parse in its most general form (multiple licenses, multiple URLs).
It seems reasonable to expose those so that the code can be reused without trying to parse the stringified versions of the licenses.