Fix vote snapshot to proposal creation block#7
Open
Sukanto01899 wants to merge 1 commit intomarkcarey:mainfrom
Open
Fix vote snapshot to proposal creation block#7Sukanto01899 wants to merge 1 commit intomarkcarey:mainfrom
Sukanto01899 wants to merge 1 commit intomarkcarey:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes vote snapshotting to always use the proposal’s creation block. Previously the snapshot block was computed using the current votingDelay, so if votingDelay was changed after a proposal was created, vote power could be calculated at the wrong block. Now each proposal stores creationBlock and voting uses that fixed block for consistent results.
Changes:
Add creationBlock to Proposal storage
Set it in propose()
Use it in castVoteInternal() for getPriorVotes
Note:
Storage layout change (new field added)