Refactor: Convert all tests to use multiprocessing queues#382
Merged
Refactor: Convert all tests to use multiprocessing queues#382
Conversation
Why is this happening? cruiz works in a multiprocessing way. And while single process tests are easier to work with to test more of cruiz, such as core functionality of message processing which checks for Conan symbols being brought over, this cannot be done in a single process, because Conan is imported by the workers, so the workers cannot be run in the same process.
I think this was no longer covered, because now all the tests run in multiprocess mode there's nothing in the test process that is adding the local cache environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this happening?
cruiz works in a multiprocessing way. And while single process tests are easier to work with to test more of cruiz, such as core functionality of message processing which checks for Conan symbols being brought over, this cannot be done in a single process, because Conan is imported by the workers, so the workers cannot be run in the same process.