Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 22, 2026

Also verified that the modification to Jackson dependencies is no longer needed for ml-gradle to work, as it's using Jackson 2.20.x as well.

@rjrudin rjrudin requested a review from BillFarber as a code owner January 22, 2026 22:17
Copilot AI review requested due to automatic review settings January 22, 2026 22:17
@rjrudin rjrudin requested a review from stevebio as a code owner January 22, 2026 22:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the example project to use the official 2.0.0 release of Flux instead of the 2.0-SNAPSHOT version, and removes workarounds for Jackson version conflicts that are no longer necessary due to compatibility improvements.

Changes:

  • Updated Flux API and embedding model dependencies from 2.0-SNAPSHOT to 2.0.0
  • Removed Jackson version resolution strategy workaround from buildscript configuration
  • Updated ml-gradle plugin from version 6.0.1 to 6.1.0
  • Added documentation for embedding model dependencies and clarified historical Jackson conflict resolution requirements

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
examples/client-project/build.gradle Updated dependencies to 2.0.0 release versions and removed Jackson resolution strategy workaround
docs/api.md Added embedding model dependency documentation and clarified that Jackson workaround was only needed prior to 2.0.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/api.md Outdated
you will likely want to include one of the following, depending on which embedding model you are using:

- For Azure OpenAI, include `com.marklogic:flux-embedding-model-azure-open-ai:2.0.0`.
- For miniml, include `com.marklogic:flux-embedding-model-miniml:2.0.0`.
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The embedding model name 'miniml' appears to be misspelled. Based on the dependency in the example project (flux-embedding-model-minilm), this should be 'minilm'.

Suggested change
- For miniml, include `com.marklogic:flux-embedding-model-miniml:2.0.0`.
- For minilm, include `com.marklogic:flux-embedding-model-minilm:2.0.0`.

Copilot uses AI. Check for mistakes.
Also verified that the modification to Jackson dependencies is no longer needed for ml-gradle to work, as it's using Jackson 2.20.x as well.
@rjrudin rjrudin merged commit 67acaa6 into develop Jan 23, 2026
3 checks passed
@rjrudin rjrudin deleted the feature/bumps branch January 23, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants