Skip to content

Omit an initial dash of header property names #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anazawa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Omit an initial dash of header property names #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33fb131
more tests for header_props()
Mar 31, 2013
a528d7a
pass hashref to CGI#header explicitly
Mar 31, 2013
46f25d9
no need to call header_props()
Mar 31, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/CGI/Application.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,8 +657,8 @@ sub _send_headers {
my $type = $self->header_type;

return
$type eq 'redirect' ? $q->redirect( $self->header_props )
: $type eq 'header' ? $q->header ( $self->header_props )
$type eq 'redirect' ? $q->redirect( $self->{__HEADER_PROPS} )
: $type eq 'header' ? $q->header ( $self->{__HEADER_PROPS} )
: $type eq 'none' ? ''
: croak "Invalid header_type '$type'"
}
Expand All @@ -670,8 +670,8 @@ sub _send_psgi_headers {
my $type = $self->header_type;

return
$type eq 'redirect' ? $q->psgi_redirect( $self->header_props )
: $type eq 'header' ? $q->psgi_header ( $self->header_props )
$type eq 'redirect' ? $q->psgi_redirect( $self->{__HEADER_PROPS} )
: $type eq 'header' ? $q->psgi_header ( $self->{__HEADER_PROPS} )
: $type eq 'none' ? ''
: croak "Invalid header_type '$type'"

Expand Down
13 changes: 12 additions & 1 deletion t/header_props.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

use strict;
use Test::More tests => 9;
use Test::More tests => 10;

BEGIN{use_ok('CGI::Application');}

Expand Down Expand Up @@ -92,3 +92,14 @@ $ENV{CGI_APP_RETURN_ONLY} = 1;

}

{
my $app = CGI::Application->new;

$app->header_props( type => 'banana/ripe' );

like(
$app->run,
qr{Content-type: banana/ripe}i,
"an initial dash of prop. name can be omitted",
);
}