Skip to content

Testing sonar PR integration#1

Open
marturi wants to merge 16 commits intomasterfrom
TEST
Open

Testing sonar PR integration#1
marturi wants to merge 16 commits intomasterfrom
TEST

Conversation

@marturi
Copy link
Owner

@marturi marturi commented Oct 21, 2016

No description provided.

package example;

public class HelloWorld {
public class HelloWorld implements Cloneable {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Add a "clone()" method to this class. rule



public void morenotCovered() {
System.out.println("morenotCovered");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule
MINOR Define a constant instead of duplicating this literal "morenotCovered" 3 times. rule

}

public void morenotCovered2() {
System.out.println("morenotCovered");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

}

public void morenotCovered3() {
System.out.println("morenotCovered");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

@@ -16,5 +16,16 @@ public void coveredByIntegrationTest() {
public void notCovered() {
System.out.println("notCovered");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

public class HelloWorld implements Cloneable {

public void coveredByUnitTest() {
System.out.println("coveredByUnitTest1");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

@marturi
Copy link
Owner Author

marturi commented Oct 21, 2016

SonarQube analysis reported 11 issues

  • CRITICAL 1 critical
  • MAJOR 9 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR [HelloWorld.java#L7](https://github.com/marturi/sonar-examples/blob/30b1bed13014893267a079958dafccd8fb6ae542/projects/languages/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app/src/main/java/example/HelloWorld.java#L7): Replace this usage of System.out or System.err by a logger. rule
  2. MAJOR [HelloWorld.java#L11](https://github.com/marturi/sonar-examples/blob/30b1bed13014893267a079958dafccd8fb6ae542/projects/languages/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app/src/main/java/example/HelloWorld.java#L11): Replace this usage of System.out or System.err by a logger. rule
  3. MAJOR [HelloWorld.java#L12](https://github.com/marturi/sonar-examples/blob/30b1bed13014893267a079958dafccd8fb6ae542/projects/languages/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app/src/main/java/example/HelloWorld.java#L12): Replace this usage of System.out or System.err by a logger. rule
  4. MAJOR [HelloWorld.java#L13](https://github.com/marturi/sonar-examples/blob/30b1bed13014893267a079958dafccd8fb6ae542/projects/languages/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app/src/main/java/example/HelloWorld.java#L13): Replace this usage of System.out or System.err by a logger. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant