WIP: Move formatters etc. into own file + tests#173
Closed
dexX7 wants to merge 1 commit intomastercoin-MSC:mscore-0.0.9from
Closed
WIP: Move formatters etc. into own file + tests#173dexX7 wants to merge 1 commit intomastercoin-MSC:mscore-0.0.9from
dexX7 wants to merge 1 commit intomastercoin-MSC:mscore-0.0.9from
Conversation
|
Nice to have the tests as part of make fore sure. and need @zathras-crypto and @faizkhan00 on this as well. Thanks! |
Author
|
Agreed, mastercore_format is a much better choice. It may also be considered to move into a seperate directory and get rid of the mastercore_ prefix. By using one or more namespaces, hints such as __MP() could be further removed. |
00446c4 to
ce1913c
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests pass and building, using the client works as expected.
The
Format__MPtests should cover almost everything, tests forstrToInt64were copied from zathras,rounduint64has none.strprintfwas an alias fortfm::formatin util.h which refers to tinyformat.h which seems to have many boost dependencies.I'm not sure about function names. Upper case, lower case, ...?
Also note:
FormatDivisibleMPandFormatIndivisibleMPwere in namespacemastercore. If they should be in an explicit mastercore namespace, then I suggest to remove the MP suffix.